<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 12/17/2014 03:35 PM, Alin Rauta
wrote:<br>
</div>
<blockquote
cite="mid:1418830536-630-1-git-send-email-alin.rauta@intel.com"
type="cite">
<pre wrap="">Hi Tom,
I've formatted the patch based on our previous discussions. This one has support only for adding FDB entries.
An example configuration is like below:
[Match]
Name=em1
[Network]
DHCP=v4
[BridgeFDB]
MACAddress=44:44:12:34:56:71
VLANId=9
[BridgeFDB]
MACAddress=44:44:12:34:56:70
VLANId=2
br0
Please let me know what you think.
Thanks,
Alin</pre>
</blockquote>
<br>
<br>
If I start trying to match this with the entire type network files
and their path ( feel free to correct me where I'm wrong here ) <br>
It would have to look like this...<br>
<br>
### em1.link ###<br>
<br>
[Link]<br>
Name=em1<br>
MACAddress=44:44:12:34:56:70
<br>
MTUBytes=9216<br>
<br>
### vlan2.netdev ###<br>
<br>
[NetDev]<br>
Name=vlan2<br>
Kind=vlan<br>
<br>
[VLAN]<br>
Id=2<br>
<br>
### em1.network ###<br>
<br>
[Match]<br>
Name=em1<br>
Bridge=bridge0<br>
VLAN=vlan2<br>
<br>
[Network]<br>
DHCP=v4<br>
<br>
[BridgeFDB]<br>
MACAddress=44:44:12:34:56:70<br>
VLANId=2 <br>
<br>
### bridge0.netdev ###<br>
<br>
[NetDev]<br>
Name=bridge0<br>
Kind=bridge<br>
<br>
### bridge0.netdev ###<br>
<br>
<br>
### em2.network ###<br>
<br>
[Match]<br>
Name=em2<br>
Bridge=bridge0<br>
VLAN=vlan9<br>
<br>
[Network]<br>
DHCP=v4<br>
<br>
[BridgeFDB]<br>
MACAddress=44:44:12:34:56:71<br>
VLANId=9<br>
<br>
### vlan9.netdev ###<br>
<br>
[NetDev]<br>
Name=vlan9<br>
Kind=vlan<br>
<br>
[VLAN]<br>
Id=9<br>
<code></code><br>
### em2.link ###<br>
<br>
[Link]<br>
Name=em2<br>
MACAddress=44:44:12:34:56:71<br>
MTUBytes=9216<br>
<br>
My fyrst question is can you really have two [BridgeFDB] entries
which contains two different mac address being matched to the same
interface ( em1 like you do in your example )? <br>
<br>
If the answer to that is yes then my question is should those
entries not belong in the bridge.netdev file<br>
<br>
If the answer to that is no then my questions are.. <br>
<br>
Do you really need to define an [BridgeFDB] entry since the [Match]
entry in the network file contains the matched link ( em1.link )
which in turn contains the MACAddress and the VLAN entry in the
[Match] entry in the network file contains the vlan which in turn is
spesified in the netdev file which contains the vlan id? <br>
<br>
Assuming you have to flush *all* BridgeFDB entries for all the
interfaces tied to a bridge, should it not be enough to flush the
bridge0 device itself? <br>
<br>
Feel free to correct me where I'm wrong here. <br>
<br>
JBG<br>
<br>
Aside note from an administrator point of view I feel we should drop
the .netdev file and replace it with each type netdev instead so in
the sample above we would have <br>
bridge0.bridge<br>
vlan2.vlan, <br>
vlan9.vlan <br>
<br>
along with<br>
<br>
em1.link<br>
em2.link<br>
<br>
em2.network<br>
em2.network<br>
<br>
<br>
</body>
</html>