<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 20, 2015 at 2:04 PM, Lennart Poettering <span dir="ltr"><<a href="mailto:lennart@poettering.net" target="_blank">lennart@poettering.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On Fri, 10.04.15 22:27, Adam Goode (<a href="mailto:agoode@google.com">agoode@google.com</a>) wrote:<br>
<br>
> USB and PCI soundcards have a nice set of ID_* properties. It would<br>
> be handy for firewire soundcards to have the same.<br>
> ---<br>
>  rules/78-sound-card.rules | 7 ++++---<br>
>  1 file changed, 4 insertions(+), 3 deletions(-)<br>
><br>
> diff --git a/rules/78-sound-card.rules b/rules/78-sound-card.rules<br>
> index bd7a994..e529f70 100644<br>
> --- a/rules/78-sound-card.rules<br>
> +++ b/rules/78-sound-card.rules<br>
> @@ -41,9 +41,10 @@ IMPORT{builtin}="hwdb"<br>
>  SUBSYSTEMS=="usb", IMPORT{builtin}="usb_id"<br>
>  SUBSYSTEMS=="usb", GOTO="skip_pci"<br>
><br>
> -SUBSYSTEMS=="firewire", ATTRS{vendor_name}=="?*", ATTRS{model_name}=="?*", \<br>
> -  ENV{ID_BUS}="firewire", ENV{ID_VENDOR}="$attr{vendor_name}", ENV{ID_MODEL}="$attr{model_name}"<br>
> -SUBSYSTEMS=="firewire", ATTRS{guid}=="?*", ENV{ID_ID}="firewire-$attr{guid}"<br>
> +SUBSYSTEMS=="firewire", ATTRS{guid}=="?*", \<br>
> +  ENV{ID_BUS}="firewire", ENV{ID_SERIAL}="$attr{guid}", ENV{ID_SERIAL_SHORT}="$attr{guid}", \<br>
> +  ENV{ID_VENDOR_ID}="$attr{vendor}", ENV{ID_MODEL_ID}="$attr{model}", \<br>
> +  ENV{ID_VENDOR}="$attr{vendor_name}", ENV{ID_MODEL}="$attr{model_name}"<br>
<br>
</span>You appear to be removing setting of ID_ID here. Is that intended?<br>
<span class=""><font color="#888888"><br><br></font></span></blockquote><div>I can document with a comment, but by defining ID_SERIAL we get the fallthrough to this line below which does what we want (once patch #1 is submitted removing $attr{id}):</div><div><br></div><div>ENV{ID_SERIAL}=="?*", ENV{ID_USB_INTERFACE_NUM}=="", ENV{ID_ID}="$env{ID_BUS}-$env{ID_SERIAL}"</div><div> </div><div><br></div></div><br></div><div class="gmail_extra">Thanks,</div><div class="gmail_extra"><br></div><div class="gmail_extra">Adam</div><div class="gmail_extra"><br></div></div>