[Tango-artists] patch to fix icon-naming-utils KDE mapping dirs
vslavik at fastmail.fm
Wed Jan 25 17:52:27 PST 2006
Rodney Dawes wrote:
> KDE doesn't expect some icons to be in exact directories, it simply
> limits the contexts, and requires that the icons be in any of those
Yes (as I wrote right after the part you quote).
> This is rather unfortunate, however, there are patches
> which will solve this problem, available at:
Not only are these patches a little too Tango specific to be likely to
get into the upstream, IMHO (and you don't seriously expect people
other then Gentoo users to recompile kdelibs just to try out Tango,
do you?), they don't completely fix this -- icons that are actions
for KDE won't show in Actions part of icons selector dialog as far as
I can tell.
> > Attached are two patches: legacy-links-dir.patch changes
> > icon-name-mapping script so that it accepts directory name in the
> > <link> element like this:
> This actually makes maintaining an icon theme which uses the utils,
> much more difficult.
I can't figure out what you mean by this... What's the difference?
There's already so many symlinks that if you want to browse the Tango
icons, you have to use the sources anyway (at least I quickly get
lost among all the symlink-duplicates).
> Given this, and the availability of the two
> patches for kdebase and kdelibs linked on the page above, I will
> not be committing your patches.
It's your project, of course, I just find it more than a little bit
weird that you take pains to develop legacy mapping tool, but then
decide to leave it in broken state that is only usable for GNOME on
purpose. On one hand, you add lots of KDE aliases to the mapping
file, on the other hand you insist on making sure they'll be
completely useless unless people patch and recompile their system...
That kind of goes against the purpose of the tool, doesn't it?
Anyway, is this fix completely unacceptable for you or would you
accept it if it did this only as optional action (via command line
argument) or if the dirs mapping was stored in different file or if
the working KDE symlinks were created in addition to (and not instead
of) the broken ones?
PGP key: 0x465264C9, available from http://pgp.mit.edu/
More information about the Tango-artists