[Bug 21295] If no alias is set then local JID part is returned as the alias instead of the full JID

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Apr 28 15:16:17 CEST 2009


http://bugs.freedesktop.org/show_bug.cgi?id=21295


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk>  2009-04-28 06:16:16 PST ---
(In reply to comment #2)
> create_room_identity: a comment explaining the logic of this check would be
> good:
> +  if (source == GABBLE_CONNECTION_ALIAS_FROM_JID)

Having done so, merged. Thanks!

commit 654246b152e630dae459b76be4fca0472e3a7e56
Merge: 147fa58 fc2a2e9
Author: Will Thompson <will.thompson at collabora.co.uk>
Date:   Tue Apr 28 14:13:03 2009 +0100

    Merge branch 'full-jid-as-fallback-alias'

    Fixes fd.o#21295.

    Reviewed-by: Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>

 src/conn-aliasing.c                           |  102 +++++++++----------------
 src/muc-channel.c                             |   18 ++++-
 tests/twisted/vcard/test-alias-empty-vcard.py |    4 +-
 tests/twisted/vcard/test-vcard-cache.py       |    4 +-
 4 files changed, 58 insertions(+), 70 deletions(-)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the telepathy-bugs mailing list