[Bug 23164] telepathy-glib-0.7.33 fails test

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 6 20:35:04 CEST 2009


http://bugs.freedesktop.org/show_bug.cgi?id=23164


Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.collabora.co.uk/?
                   |                            |p=user/wjt/telepathy-
                   |                            |glib.git;a=commitdiff;h=refs
                   |                            |/heads/dont-unref-null-
                   |                            |message
           Keywords|                            |patch




--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk>  2009-08-06 11:35:04 PST ---
Most of these are unneeded, because the surrounding code already checks that
the message is non-NULL. But one of the dbus_message_unref (reply) calls is in
an if (reply == NULL) {} block, which is wrong. The patch at
<http://git.collabora.co.uk/?p=user/wjt/telepathy-glib.git;a=commitdiff;h=refs/heads/dont-unref-null-message>
should fix it properly; could you check that it works for you?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the telepathy-bugs mailing list