[Bug 23275] Add C++ visibility support

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23275


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |




--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-08-18 08:12:33 PST ---
Rejected for now, please re-add patch tag when you've fixed it.

(In reply to comment #3)
> Despite the XXX::Private methods I don't see any other symbol that should not
> be there. Should we add TELEPATHY_QT4_NO_EXPORT to all Private structs?

Yes, definitely. At the moment, they're part of our shared library ABI; that
means that we should never remove, rename, or change the semantics of these
methods, which isn't desirable.

Also, if we have any private methods on public objects, we should make sure
they're not exported either.

> Also exported non-class methods, enableDebug, registerTypes, ...

The extra patch looks fine.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.