[Bug 20829] Implement ContactSearch (telepathy-spec 0.17.22 version)

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=20829





--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk>  2009-08-24 08:17:25 PST ---
parse_data_form:

  gboolean found_form_type_search = FALSE;
          found_form_type_search = TRUE;

but then it's never actually used again.

      tp_name = g_hash_table_lookup (xmpp_to_tp, var);
      if (tp_name != NULL)
        {
          g_ptr_array_add (search_keys, tp_name);
          g_hash_table_insert (self->priv->tp_to_xmpp, g_strdup (tp_name),
              g_strdup (var));

So what happens if a form contains two fields that map to the same Telepathy
name? I think that the key will appear twice in AvailableSearchKeys, and when
the client calls Search() the last field name seen will be used. The former is
a slight bug but it's harmless; the latter is also valid. Maybe there should be
a test to make sure Gabble doesn't implode when this happens, and if you're
feeling really keen, code to avoid duplicates?

--

add_search_result() builds the 'n' field from the separate given and family
components. It should also use the middle name if present, maybe? Also, should
we be constructing an 'org' field out of x-org-unit and x-org-name? Ditto
'adr'? "No" is a reasonable answer. :)

======

Here endeth the review!


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.