[Bug 22231] [MC5] Need gnome-keyring integration

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=22231





--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-08-25 04:02:26 PST ---
<http://git.collabora.co.uk/?p=user/jonny/telepathy-mission-control.git;a=commitdiff;h=a744d9904
account_remove_cb>:
> +    if (error != NULL)
>      {
> -       if (!error)
> -           g_set_error (&error, TP_ERRORS, TP_ERROR_NOT_AVAILABLE,
> -                        "Internal error");
> -       dbus_g_method_return_error (context, error);
> -       g_error_free (error);
> -       return;
> +        error_copy = g_error_copy (error);
> +        dbus_g_method_return_error (data->context, error_copy);
> +        return;
>      }

I think this leaks the error? dbus_g_method_return_error doesn't steal it.

<http://git.collabora.co.uk/?p=user/jonny/telepathy-mission-control.git;a=commitdiff;h=436c5535c83>:
+/**
  * _mcd_account_set_parameters:

This is deliberately not gtkdoc'd - even when MC is compiled as a library, it's
not part of the library.

+static GHashTable *
+hash_table_copy (GHashTable *orig)

Use tp_g_hash_table_update instead of g_hash_table_foreach, please.

+            /* we assume that the TpConnectionManager won't get
+             * freed */

Couldn't you, you know, ref it? I know the assumption is initially mine, but it
becomes more questionable when you're doing things asynchronously.

(I'm not 100% sure how McdManager works...)

+static void
+get_parameter (McdAccount *account, const gchar *name,
+               McdAccountGetParameterCb callback, gpointer user_data,

I don't like the way this has a "goto error" passing a GError that can be NULL
to the callback.

Review still in progress...


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.