[Bug 22231] [MC5] Need gnome-keyring integration

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=22231





--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2009-08-25 08:06:59 PST ---
(In reply to comment #1)
> I think this leaks the error? dbus_g_method_return_error doesn't steal it.

Right. I'm not quite sure I didn't see the "const" on the error parameter.

> This is deliberately not gtkdoc'd - even when MC is compiled as a library, it's
> not part of the library.

Okay, removed extra asterisk.

> Use tp_g_hash_table_update instead of g_hash_table_foreach, please.

Done.

> Couldn't you, you know, ref it? I know the assumption is initially mine, but it
> becomes more questionable when you're doing things asynchronously.

Okay, I just duped the strings. This was actually already fixed in 2/3 of the
places where the comment was.

> I don't like the way this has a "goto error" passing a GError that can be NULL
> to the callback.

Already fixed.

> Review still in progress...

I'm hot on your heels!

I'm just cleaning up some commit messages as you requested.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.