[Bug 22231] [MC5] Need gnome-keyring integration

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=22231





--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-08-25 11:55:15 PST ---
+static void
+_mcd_account_delete (McdAccount *account,
+                     McdAccountDeleteCb callback,
+                     gpointer user_data)
 {
     McdAccountPrivate *priv = account->priv;
     gchar *data_dir_str;
     GDir *data_dir;
     GError *kf_error = NULL;
+    AccountDeleteData *delete_data;

     if (!g_key_file_remove_group (priv->keyfile, priv->unique_name,
                                   &kf_error))
@@ -614,8 +637,8 @@ _mcd_account_delete (McdAccount *account, GError **error)
         else
         {
             g_warning ("Could not remove group (%s)", kf_error->message);
-            g_propagate_error (error, kf_error);
-            return FALSE;
+            callback (account, kf_error, user_data);
+            return;

This leaks kf_error, I think?

+complete_account_creation_set_cb (McdAccount *account, GPtrArray *not_yet,
...
+    if (cad->ok)
+    {
+        add_account (account_manager, account);
+        mcd_account_check_validity (account, complete_account_creation_finish,
cad);
+    }
+    else
+    {
+        complete_account_creation_finish (account, TRUE, cad);

Is this TRUE meant to be FALSE?

get_parameter() doesn't always set an error, which is apparently fixed in a
later patch. I should check that based on what's at HEAD.

"mcd-account: copy strings in not_yet callback argument" should be squashed
into the patch(es) that it fixes; so should "mcd-account: on error never give
not_yet as it's not filled".

How's the test coverage?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.