[Bug 22231] [MC5] Need gnome-keyring integration

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=22231


Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch




--- Comment #5 from Jonny Lamb <jonny.lamb at collabora.co.uk>  2009-08-26 05:18:50 PST ---
(In reply to comment #3)
> This leaks kf_error, I think?

Fixed.

> Is this TRUE meant to be FALSE?

No. This would report to complete_account_creation_finish that the CM
parameters supplied are invalid, which isn't actually the problem. I had,
however, neglected to report an error back. This is now fixed.

> get_parameter() doesn't always set an error, which is apparently fixed in a
> later patch. I should check that based on what's at HEAD.

Yeah, it's fixed in HEAD.

> "mcd-account: copy strings in not_yet callback argument" should be squashed
> into the patch(es) that it fixes; so should "mcd-account: on error never give
> not_yet as it's not filled".

These have been squashed into "mcd-account: refactored set_parameters to be
async and iteratively set params".

> How's the test coverage?

I haven't added any tests because in my opinion, I haven't added any new
features that aren't already being tested -- the tests you already wrote appear
pretty good. I guess the tests take different code paths depending on
--enable-gnome-keyring.

It should be noted that all the tests still pass. :-)


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.