[Bug 24258] Improve valgrind-cleanness

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Dec 3 18:45:07 CET 2009


--- Comment #4 from David Laban <david.laban at collabora.co.uk>  2009-12-03 09:45:07 PST ---

> > http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=commitdiff;h=94dae71c582130aa053c953311b604b6d8f04e28
> > which required me to look both at the commit message and the full source to see
> > what was going on. Would having a VALGRIND_TESTS variable make it clearer?
> It would make this diff clearer, but at the cost of adding a somewhat
> pointless layer of abstraction.

Ok. Leave it as it is then. I guess if it all fits on one page, then anyone
who's ever used valgrind on a python interpreter will be able to glance at it
and see what you're doing. 

Ship it.

Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the telepathy-bugs mailing list