[Bug 20831] ContactInfo: implement and undraft

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=20831





--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-12-08 06:05:42 PST ---
Removing the patch keyword while you respond to Will's review; please put it
back when this branch is ready for more review.

(In reply to comment #3)
> > >       GError tp_error = { TP_ERRORS, TP_ERROR_NOT_AVAILABLE,
> > >           vcard_error->message };
> > 
> > We could map GABBLE_VCARD_MANAGER_ERROR_CANCELLED to TP_ERROR_CANCELLED, for
> > instance.
> >
> I see one problem here, IMHO the spec should state this first then we implement
> it. The spec does not say anything about invalid handles netiher
> TP_ERROR_CANCELLED is a valid error. I let this as is and then we can decide
> what to do later (update spec first? implement first? ...)

As spec maintainer, my position is that any method can raise any error; the
ones in the spec provide a hint to clients about the errors they can expect to
see, and provide a hint to services about the correct representation for
particular errors. If there are more errors that would be appropriate, please
use them, and open an enhancement bug against telepathy-spec (ideally with a
patch).


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.