[Bug 25422] generate code for Call draft API

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Dec 8 15:27:45 CET 2009


http://bugs.freedesktop.org/show_bug.cgi?id=25422





--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-12-08 06:27:44 PST ---
(In reply to comment #2)
> I wouldn't object to renaming the generated function to _registerTypes and
> making it unconditionally TELEPATHY_QT4_NO_EXPORT, then adding a handwritten
> Tp::registerTypes() that just calls Tp::_registerTypes and
> TpFuture::_registerTypes?

I've done this on my branch, please re-review.

> > Also I would change the namespace to Tp::Future instead
> > of TpFuture, so using namespace Tp; works

I think we agreed on IRC that TpFuture was, in fact, appropriate, since the
generated future code is not part of the library API or ABI (that's the whole
point), so I haven't changed this.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list