[Bug 21594] Implement being a Handler

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=21594





--- Comment #9 from Andre Moreira Magalhaes <andrunko at gmail.com>  2009-05-19 06:07:23 PST ---
(In reply to comment #6)
> In ChannelRequest::Private::Private():
> +    // readinessHelper->becomeReady(Features() << FeatureCore);
> 
> This should probably be deleted rather than commented out.
Fixed.

> + * The client registrar will be responsible for proper exporting the client
> + * D-Bus interfaces, based on inheritance.
> 
> I can't really parse this. I think I'd say “The client registrar will export
> the appropriate D-Bus interfaces, based on the abstract classes subclassed by
> \param client” or something.
Fixed.

> MethodInvocationContext only supports returning <= 8 values? This seems like an
> unfortunate arbitrary limitation. Can it be raised without an ABI break?
This is a chosen limitation. QDBusPendingReply already supports only <=8
values, so we chose to use the same. Also 8 is a common default value used in
C++ templates supporting multiple values.

> Why is Q_DISABLE_COPY(MethodInvocationContext) in the private: section? Other
> classes have it as the first thing inside class ____ {
As there are some typedefs there, I prefer to move the declaration to the
private section, it looked better to me, but I can change that if you prefer.

>  ---
> 
> That's my review finished, up to 8c26060d417a68ca65affb73edb5828bd056dea0.
> 
> Simon's comments have all been fixed. So I guess the above four points are all
> that's left.
> 


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.