[Bug 24654] _tp_account_check_features can use uninitialized variables

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24654





--- Comment #4 from David Laban <david.laban at collabora.co.uk>  2009-11-16 19:18:15 PST ---
It does indeed seem to fix the bug. Initial efforts are to be found in [1], but
the fix should probably also be applied to TpAccountManager and rebased to
master (where there is another place it might need to be freed).

I really don't like copy-pasted code, but most of my code in AccountManager
recently seems to be copy-pasted from Account. Should I be refactoring out the
features code now, or waiting until someone has an implementation of the
non-trivial case?

[1]
http://git.collabora.co.uk/?p=user/alsuren/telepathy-glib.git;a=shortlog;h=refs/heads/fix-24654


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.