[Bug 23284] Add support for ContactCapabilities interface

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23284





--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2009-10-06 09:32:44 PST ---
>From IRC, with some parallel conversations deleted:

17:20 < smcv> andrunko: what you want to be able to do in a UI is: should I 
              display a microphone icon in Empathy or not?
17:21 < smcv> andrunko: if the capabilities object is always non-NULL you can 
              just do contact->capabilities()->supportsAudioCalls()
17:21 < smcv> andrunko: but if the capabilities object can be NULL, you need to 
              put a pile of NULLness checks in to not crash
17:22 < smcv> andrunko: I confidently predict that basically all UIs will want 
              to treat "unknown caps" and "known to have no caps" as synonymous
17:22 < smcv> andrunko: and similarly, they'll want to treat XMPP 
              this-guy-can-do-audio as synonymous with SIP 
              people-can-probably-do-audio
17:23 < wjt> smcv: so why should Gabble expose the difference between the two?
17:23 < wjt> (i agree with you that no UI cares about the difference)
17:23 < smcv> wjt: a valid point. perhaps it shouldn't
17:23 < smcv> wjt: although in Gabble things are clouded by the fact that there 
              are "assumed capabilities" like Text
...
17:26 < smcv> andrunko: I think I'd find it easier to see what you intend about 
              caps if you could come up with a code snippet that e.g. Kopete 
              could use for "given this not-necessarily-ready Contact, should I 
              display a microphone icon?"
17:27 < smcv> andrunko: (i.e. it would run this code snippet on setup, when 
              upgradeCapabilities returned, and on every capabilitiesChanged 
              signal)
17:28 < andrunko> but we would not have an extra object for each contact with 
                  no caps
17:28 < smcv> andrunko: I meant they'd all have a pointer to a shared singleton 
              sort of thing
17:28 < smcv> andrunko: could you post a code snippet to the bug so I can 
              understand how you intend UI code to look?
17:29 < andrunko> ahh don't know, let me post a code snippet
17:30 < smcv> andrunko: you may assume that Core is ready on the Connection if 
              you want, but I think code like this should be non-ugly if 
              optional features might still be in-progress


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.