[Bug 23684] Gabble advertizes an avatar's sha1 in its presence stanza without following XEP-0153

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=23684





--- Comment #13 from Alban Crequy <alban.crequy at collabora.co.uk>  2009-10-08 08:46:57 PST ---
(In reply to comment #12)
> +    sync_stream(q, stream) # Twice because the vCard request is done in
> +    sync_stream(q, stream) # g_idle_add
> 
> Does this actually reliably give the idle a chance to run?

In practice, yes. However I am not sure about the theory.

> 6f705c81fc7cec means that we leak presence->avatar_sha1 when doing
> conflict resolution: self_avatar_resolve_conflict() sets it to NULL
> without freeing it. Either it should free it, or not set it to NULL.

Sorry, my mistake. I wanted to do the free() near the place where it is set to
NULL. Fixed.

Other comments fixed too.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.