[Bug 24641] New: patch: refactor tools/c-constants-gen.py to look a bit less horrible.

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24641

           Summary: patch: refactor tools/c-constants-gen.py to look a bit
                    less horrible.
           Product: Telepathy
           Version: unspecified
          Platform: Other
               URL: http://git.collabora.co.uk/?p=user/alsuren/telepathy-
                    glib.git;a=shortlog;h=refs/heads/constants-cleanup
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: david.laban at collabora.co.uk


I was discussing code generation with a few people, and they said to look at
how tp-glib does it. I took one look at it and thought "this looks horrible".
istaz agreed so I spent a few hours re-factoring one of the files. It currently
produces the exact same output as it did in master, but with only one print
statement per function. I hope you like it.

Patch can be found in
http://git.collabora.co.uk/?p=user/alsuren/telepathy-glib.git;a=shortlog;h=refs/heads/constants-cleanup
but I suspect the patch is far uglier to read than the new code because I've
changed the structure quite a lot.

If you like this patch, I can work my magic on the rest of tp-glib/tools and
tp-python/tools too.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.