[Bug 21957] Doesn't implement SimplePresence

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=21957


jonner <jonathon at quotidian.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #6 from jonner <jonathon at quotidian.org>  2009-10-20 21:33:19 PST ---
(In reply to comment #5)
> +       /* no need to continue querying member presence after we close the
> channel
> +        */
> 
> This is going to need updating to deal with respawning channels (which I
> thought was in master, but maybe isn't).

Can you explain this a bit to me?  How does channel re-spawning work?

> +        * FIXME: avoid this for large rooms?
> 
> Or make it even less frequent?

ok, I lengthened this timeout to 120s for now

> Before this is merged, we need to fix the bug where Idle sends at most
> one message a second, because otherwise if you have >20 IM channels open
> (or fewer and are sending messages for some other reason) the WHO/WHOIS
> requests will back up.

Agreed.  I'll work on this next.

> I wonder if we should treat contacts whose away message is "Away" (case
> insensitively) as if they had no away message. This would mean such
> contacts would show up in Empathy with the localized version of "away".

good idea.  I've implemented this.  As a bonus, xchat-gnome (and I guess xchat
proper) default to setting the message to "Away" as well (at least when run in
the english locale), so we'll get a little interoperability there as well.

> I like the final patch to try to cache the most informative version of
> the contact's presence!

Yeah, unfortunately, this has some downsides as well (as most hacks do).  For
instance, when implementing the localized Away message (above), I had to be
careful not to just omit the status message, or otherwise if a contact had an
away status of "foo" and then switched it to "Away", it would attempt to
continue to use the cached "foo" presence status.

> The issue of figuring out that the whois reply doesn't contain an away
> reply and inferring that they're available is kind of unfortunate.
> Perhaps the contact manager could hook into the beginning of the WHOIS
> reply, and then if it gets ENDOFWHOIS without getting AWAY decide that
> the contacts is available?

This sounds a bit complex, so I've avoided it for now.  Perhaps I'll take a
stab at it a little later.  I've pushed changes for most of the other issues to
my branch on dhansak for now.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.