[Bug 24699] New: should not abuse Message_Type_Action for nudges

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24699

           Summary: should not abuse Message_Type_Action for nudges
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: butterfly
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk


16:06 < smcv> does MSN have the concept of an action message?
16:06 < smcv> arguably Empathy should turn (ACTION, "drinks heavily") into 
              (NORMAL, "*** drinks heavily") for protocols that can't do 
              actions properly
16:06 < istaz> wjt: well it only support if it fhe action is nudge
16:07 < smcv> istaz: \o\ /o/ \o/ MSN!
16:07 < istaz> we could probably convert it inside butterfly to display a irc 
               style message
16:07 < wjt> Maybe Empathy should send "/me laughs" as-is
16:07 < smcv> istaz: hang on. so you claim to support the ACTION message type, 
              then if the action is not "nudge", you error?
16:07 < wjt> (if the CM doesn't do Message_Type_Action)
16:08 < istaz> smcv: yep
16:08 < wjt> !!
16:08 < wjt> that's not what M_T_Action is for
16:08 < smcv> istaz: please, no
16:08 < cassidy> istaz, sounds great
16:08 < smcv> istaz: that blocks the UI's ability to do what I suggested a 
              dozen lines ago, or what wjt suggested half a dozen lines ago
16:08 < smcv> having the UI be
16:08 < smcv> *** drinks heavily
16:09 < smcv> or even
16:09 < smcv> /me drinks heavily
16:09 < smcv> would be considerably better than just erroring!
16:09 < smcv> if we support nudges, it should be via an interface that can also
              support http://xmpp.org/extensions/xep-0224.html
16:09 < smcv> probably
16:09 < istaz> smcv: couldn't the ui do it when it receive an error?
16:10 < smcv> istaz: I would consider that to be deeply, deeply bong.
16:10 < smcv> istaz: "InvalidArgument" (or whatever it is you reply with) is 
              nowhere near enough information to infer "oh, this Channel that 
              claims to support ACTION secretly doesn't"
16:11 < istaz> smcv: and another ugly things is that when we receive a nudge we 
               actually send a message "<contact> sends you a nudge" (without 
               localization)
16:11 < smcv> istaz: that's wrong too, but a little less so
16:11 < istaz> smcv: I should probably fix that then
16:11 < Zdra> smcv, empathy does not uses Messages
16:11 < Zdra> smcv, and does not try any caps
16:12 < Zdra> smcv, we are using old Text iface ;)
16:12 < smcv> Zdra: ok, so Empathy is also at fault, it should call 
              Text.GetMessageTypes(), and use the result for graceful fallback
16:12 < smcv> Zdra: however, butterfly currently prevents that from working in 
              any case
16:13 < smcv> to the bug-filing-mobile!


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.