[Bug 24763] New: unclear whether there can be duplicate satisfied requests

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=24763

           Summary: unclear whether there can be duplicate satisfied
                    requests
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: low
         Component: mission-control
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk


>From Bug #24120:
> > +    /* collect object paths into a hash table, to drop duplicates */
> > +    for (c = channels; c != NULL; c = c->next)
> > +    {
> > +        const GList *reqs = _mcd_channel_get_satisfied_requests (c->data);
> > +
> >
> > Why would there be duplicate satisfied requests?
>
> Pre-existing problem, I just moved the code. I *believe* that there should
> never be duplicates, because each request is satisfied by at most one channel -
> but beware that McdChannel is sometimes a Channel and sometimes a
> ChannelRequest, so it's non-obvious.
>
> When I refactor MC so McdChannel doesn't exist (long-term goal), this can
> probably start asserting. For now, may I "resolve" this by filing a bug, and
> adding a FIXME comment referencing it?


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.