[Bug 24652] TpContact should support Location

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Apr 5 16:54:40 CEST 2010


--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-05 07:54:40 PDT ---
You'll need to update docs/reference/*-sections.txt to include the new API. In
future I'd like this to be part of the same commit that introduces it
(otherwise make check will fail); please make check with gtk-doc enabled.

(In reply to comment #4)
> > > +          tp_cli_connection_interface_location_call_get_locations (
> > 
> > I don't think this slow-path is actually needed. The Contacts interface was
> > made mandatory in 0.17.23, and Location wasn't added until 0.17.27, so I'd be
> > inclined to say that if your CM implements Location, but not Contacts, then you
> > don't deserve geolocation :-)
> I'd be tempted to keep it as:
> a) it's already done :)
> b) it keeps the code more symetric
> c) it will make testing with Empathy easier if one wants to try to implement a
> small CM implementing, say, google latittude (may actually be one of my secret
> hypothetic project ;)

OK, but only because you already implemented it :-)

I consider Contacts to be a mandatory feature in CMs, and new telepathy-glib
features shouldn't go to any particular effort to work with pre-Contacts CMs.
telepathy-qt4 already doesn't support any extra features, like the alias, on
Tp::Contact objects from an old CM.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

More information about the telepathy-bugs mailing list