[Bug 21097] proxy subclasses should support optional features

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21097

--- Comment #6 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-04-06 07:14:29 PDT ---
(In reply to comment #5)
> > +    gpointer magic;
> > A comment explaining the semantic of this pointer would be good.
> 
> Yeah, I'll add one. It's just an arbitrary "magic number" to detect
> use-after-free or whatever (and it makes the size of the struct a power of 2,
> which is probably not harmful? I'm not sure how g_slice_new pads things).

I'm not really convinced it's worth it as it doesn't give us anything.

> > +TpWeakRef *tp_weak_ref_new (gpointer object, gpointer user_data,
> > That's now how you do coding style :p
> 
> It is in declarations, unless you're enforcing a stricter policy for header
> files than we currently do (which I wouldn't necessarily oppose). /Style on the
> wiki is ambiguous, and vaguely in favour of your stricter policy.

I always apply a "one arg per line" policy in declarations assuming it was in
the policy but I don't care that much tbh.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.