[Bug 21097] proxy subclasses should support optional features

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21097

--- Comment #14 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-08 04:36:37 PDT ---
I've merged weakref based on Guillaume's approval. Further actions required
from me:

(In reply to comment #8)
> (In reply to comment #7)
> > Shouldn't we have TP_CHANNEL_FEATURE_GROUP rather than including it with CORE?

I'll consider this, but GROUP always needs to be "trying to prepare".

> > tp_channel_is_ready's doc: 
> Perhaps "New code should use t_p_i_p(), which is a more general form of this
> method"?

I'll make this change.

(In reply to comment #9)
> (In reply to comment #7)
> > +gboolean _tp_proxy_is_preparing (gpointer self, GQuark feature);
> > +void _tp_proxy_set_feature_prepared (TpProxy *self, GQuark feature,
> > +    gboolean succeeded);
> > 
> > +static void tp_proxy_poll_features (TpProxy *self, const GError *error);
> > 
> > Should be one line per arg.

Yeah, yeah, OK.

Guillaume/other reviewers, are you convinced by my reasoning for the other
stuff that I don't plan to change?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.