[Bug 27535] New: GetContactAttributes() no longer specified to be needlessly fascist about interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27535

           Summary: GetContactAttributes() no longer specified to be
                    needlessly fascist about interfaces
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: sunshine
        AssignedTo: kkszysiu at gmail.com
        ReportedBy: simon.mcvittie at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


telepathy-sunshine probably needs the same change as telepathy-butterfly, since
GetContactAttributes apparently isn't provided by telepathy-python. See the
bugs referenced below.

Will wrote the following patch for Butterfly:

http://git.collabora.co.uk/?p=telepathy-butterfly.git;a=commitdiff;h=07bd347f89195f357f69622b8d02239f663a1a3d

+++ This bug was initially created as a clone of Bug #27374 +++

+++ This bug was initially created as a clone of Bug #27325 +++

>From the definition of GetContactAttributes():

> It is an error to request interfaces that are not supported by this
> Connection (i.e. mentioned in the ContactAttributeInterfaces
> property).
>
> | This makes it possible to distinguish between interfaces for which
> | the Connection has nothing to say (e.g. we don't know the avatar
> | tokens of any of the contacts, so we omitted them all), and interfaces
> | for which this API isn't supported.

This is needlessly pedantic. If we had instead said that the CM must
ignore interfaces which aren't supported on the Contacts interface, then
client code that does care could still check ContactAttributeInterfaces
to distinguish those two cases, and client code that doesn't care
wouldn't have to mess around checking the list of interfaces it passes
to GetContactAttributes().

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.