[Bug 19164] [0.11] TpChannel:identifier represents "no identifier" both as NULL and as ""

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=19164

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-12 10:53:29 PDT ---
What TpContact does turns out to be irrelevant, since a TpContact always has a
valid identifier.

Xavier's branch implements the following semantics:

* if identifier is not known yet, return NULL
* if identifier is known to be irrelevant due to TargetHandleType = None,
return ""

This is consistent with the previous behaviour of channels with TargetID
support (i.e. increasingly many). However, I wonder whether returning a
non-NULL string from the start makes more sense?

I'm unsure about the appropriateness of the implementation: getting the
immutable properties dict will still yield an unspecified TargetID, but we can
do better.  _tp_channel_get_identifier() already has a special case for
THT=None; that special case could just be extended to set the TargetID using
_tp_channel_maybe_set_identifier before continuing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.