[Bug 26059] Requests Mixin doesn't create Handles on demand

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26059

--- Comment #2 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-04-16 14:50:09 PDT ---
Sorry for taking so long to get back to you about this.

I've cherry-picked the relevant commits from your branch and created a new one
for ease of review, although I might just squash them all into one:

http://git.collabora.co.uk/?p=user/jonny/telepathy-python.git;a=shortlog;h=refs/heads/26059

Here's a quick review:

Why did you implement get_handle_by_name? Why not just use RequestHandles and
require that it returns Handle objects (or subclasses). The problem I foresee
here is that butterfly expects all its handles to be of type ButterflyHandle.
This works because it re-implements RequestHandles. What we could do is
something like this:

-            ret.append(handle.get_id())
+            ret.append(handle)

in RequestHandles, and add a __int__() method to telepathy.server.Handle which
returns the same as get_id(). What do you think? It sounds like a cleaner
solution and nicer to CMs using tp-python (we've got to give them something!)

This solution would also mean that bug #27445 could be fixed in tp-python
instead of butterfly which is cool. Thoughts?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.