https://bugs.freedesktop.org/show_bug.cgi?id=27742
--- Comment #6 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-04-19 13:21:06 PDT ---
Review of attachment 35170:
--> (https://bugs.freedesktop.org/review?bug=27742&attachment=35170)
Just a couple of niggles. It's basically fine and seems to work.
::: src/client/account.py
@@ +22,3 @@
+from telepathy.client.interfacefactory import (InterfaceFactory,
+ default_error_handler,
+ )
Move this closing bracket to the line before.
::: src/client/accountmgr.py
@@ +22,3 @@
+from telepathy.client.interfacefactory import (InterfaceFactory,
+ default_error_handler,
+ )
Ditto for account.py.
@@ +32,3 @@
+
+ self.service_name = ACCOUNT_MANAGER
+ self.object_path = '/' + self.service_name.replace('.', '/')
Actually, the object path is hard-coded in the spec, so we should use the
'/org/free...AccountManager/' string here.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.