[Bug 25236] TpHandler - a class that implements a Client.Handler

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25236

--- Comment #6 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-04-20 04:59:52 PDT ---
Is it ok to call G_IMPLEMENT_INTERFACE even if we don't actually implement the
iface?

tp_base_client_register() should probably check that at least of the
observer/approver/handler has been set as it's not valid to be a Client without
implemeneting at least one of those interface.

Any reason to not have a observer and approver variant of
tp_base_client_be_a_handler() ?

I'm not sure CLIENT_HANDLER_BYPASSES_APPROVAL should be a flag. It's pretty
different from others flags as it doesn't affect the interfaces implemented.

Any reason to call this TpBaseClient rather than TpClient?
What should do function like _tp_base_client_observe_channels()? Call a virtual
method or... ?

implementation detai: finalize shouldn't use g_hash_table_destroy to destroy
filters.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.