[Bug 25236] TpHandler - a class that implements a Client.Handler

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Apr 20 15:10:22 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=25236

--- Comment #9 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-20 06:10:22 PDT ---
(In reply to comment #8)
> Really? I did write test approvers and observers having an empty list of
> filters. They were called for all channels.

Are you sure you mean an empty list of filters, as opposed to a list containing
only an empty filter? Here's what's meant to happen:

ApproverChannelFilters = []         # matches nothing
ApproverChannelFilters = [{}]       # matches everything
ApproverChannelFilters = [{x: y}]   # matches some things (common case)

If you really do mean that an empty list matches everything, please file a bug
on MC - it's not meant to behave like that.

> I think I prefer the virtual method + callback passed to constructor for Simple
> versions approach.
> Signals doesn't fit very well here.

Fair enough, although one reason I was in favour of using signals was that
they're probably easier to do in non-C languages. We could always make a
subclass that uses a signal (TpSignallingObserver?) though, if we need that.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list