[Bug 27751] Add a pile of API to WockyNodeTree

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27751

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-, minor changes
         AssignedTo|will.thompson at collabora.co. |sjoerd at luon.net
                   |uk                          |

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2010-04-20 07:09:26 PDT ---
I wonder whether WockyNodeTree:top-node stealing the thing you give it (rather
than copying it) will confuse bindings?

+          DEBUG ("Stanza without a namespace !?, using dummy namespace");

When will this happen?

+ * <example><programlisting>
+ * wocky_node_tree_new ("html", "http://www.w3.org/1999/xhtml",
+ *    "alice@<!-- -->collabora.co.uk", "bob@<!-- -->collabora.co.uk",
+ *    '(', "html", ':', "http://www.w3.org/1999/xhtml",
+ *      '(', "body", '@', "textcolor", "red",
+ *         '$', "Wocky wooo",
+ *      ')'
+ *   NULL);
+ * </programlisting></example>

Following in the glorious tradition of getting these examples wrong, you have
not closed the html tag.

+ * This function may only be called in non-streaming mode.
...
+  g_return_if_fail (!writer->priv->stream_mode);

I think the non-streaming mode should be a subclass. Having methods that may or
may not blow up is kind of weird.

+  destination = wocky_node_tree_new ("mainlain europe",

mainland. can you really have spaces in tag names?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.