[Bug 27772] de-obfuscate self->priv access

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27772

--- Comment #10 from Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> 2010-04-23 06:03:23 PDT ---
Due to one more commit to Simon's branch, i'm reviewing only
d84fa9686e619e4329c2b55dfaa07054ae5cff32.

in log_store_xml_get_dir(), log_store_xml_get_all_files() and
log_store_xml_get_chats() priv is assigned but actually never used, it can be
removed.

in log_store_xml_get_dir() priv is used only once, so either

1) remove the priv declaration and use self->priv instead

or

2) declare "TplLogStoreXmlPriv *priv" in the other functions in which priv
appears just once or twice.



would be appropriate IMHO.

or 3) leave it as is :)

i'd be for 1).


The rest is OK.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.