[Bug 27645] Implement SASL authentication channels.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27645

--- Comment #7 from Eitan Isaacson <eitan.isaacson at collabora.co.uk> 2010-04-23 10:20:54 PDT ---
(In reply to comment #5)
> Two minor points in review II:
> 
> server-sasl-channel.c: typo:
>     GabbleSvcChannelInterfaceAuthMechanismChooser *mechanims_chooser,
>       mechanims_chooser);
> 
> (Trivial I know, but let's not bake in typos)
> 

Fixed, thanks.

> and from review I:
> 
> "in gabble_authentication_manager_foreach_channel() only apply the function to
> 'server_sasl_handler' if it's in the middle state."
> 
> Now you check for ->closed before applying the func, but is it possible the
> function still gets applied in stats 0 (Not Announced) here?
> (It may be that something prevents this, or that it is harmless, in which 
> case fine).

The channel constructor assigns TRUE to ->closed, so the check should work also
when the channel is in the unannounced stage.

> 
> Everything else looks like it's been taken care of.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.