[Bug 27687] new GIO-style async methods for requesting TpContacts

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Apr 27 11:42:45 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=27687

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-27 02:42:45 PDT ---
(In reply to comment #4)
> So I've wondered whether a GArray and GStrv would be more useful. Than static
> arrays

GArray -> (array,len) is trivial in C - I expect about 50% of callers will
actually be using a GArray, but using ((TpHandle *) arr->pdata, arr->len) is
almost as easy, and also allows for non-GArrays.

GStrv -> (array,len) is also trivial in C, because g_strv_length() exists; I
consider it to be a significant advantage that the same API is useful for
NULL-terminated and non-NULL-terminated arrays, and in particular that
non-NULL-terminated arrays don't have to be copied in order to call the
function.

Adding a shim around the current methods to have better bindability might be
worth it if it's a common problem throughout g-i; I don't think it's right if
it's only a gjs limitation.

> I'm kind of wondering whether that's required though, or really we should just
> look into trying to fix gjs/convince someone to fix gjs.

We shouldn't add API just to work around gjs' limitations (particularly if it
works fine in other g-i languages, e.g. pygi).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list