[Bug 25236] TpBaseClient - an abstract class to implement clients

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25236

--- Comment #28 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-28 03:23:11 PDT ---
(In reply to comment #25)
> > Still to review
> > ===============
> > 
> > I haven't reviewed the test or the SimpleClient yet.
> 
> I guess you mean SimpleObserver :)

No, I meant the SimpleClient used by the regression test :-P

> I think that's ok, we can merge the Observer bits of BaseClient first. At least
> we know that it allows to easily write SimpleObserver.

Agreed. I'll re-review shortly.

(In reply to comment #27)
> (In reply to comment #25)
> > > Eventually, I'd like a code example or a reference to TpSimpleObserver (etc.)
> > > here.
> > > 
> > > It'd be nice to have an observer in examples/client/ that just does a
> > > g_message() whenever a StreamedMedia call starts or finishes, or something
> > > similarly easy.
> > 
> > Would you implement it using TpBaseClient or TpSimpleObserver?
> 
> What about referring as TpSimpleObserver as a good example of TpBaseClient
> subclass and implement the example using TpSimpleObserver ?

That'd work.

If it wasn't for all the boilerplate needed to implement a subclass, I'd say do
the example for TpBaseClient and port to TpSimpleObserver afterwards... but
then, if it wasn't for all the boilerplate needed to implement a subclass, we
wouldn't need TpSimpleObserver at all.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.