[Bug 26374] muc-calls branch review notes.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26374

--- Comment #6 from Mike Ruprecht <cmaiku at gmail.com> 2010-04-28 22:43:26 PDT ---
Test a remote party adding a video stream
dc575e2aee5c4387c5c8fb9130542557c65b43c0
+    presence = make_muc_presence('owner', 'moderator', muc, 'bob')
+    muji =  ('muji', ns.MUJI, {},
+        [('content', ns.MUJI, { "name": "Voice" },
+            [( 'description', None, {"media": "audio"},
+            jt.generate_payloads(jt.audio_codecs))]),
+         ('content', ns.MUJI, { "name": "Camera" },
+            [( 'description', None, {"media": "video"},
+            jt.generate_payloads(jt.video_codecs))]),
+        ])

Technically the description element should have the
"urn:xmpp:jingle:apps:rtp:0" namespace.


Assert that the CallState changes once our muji state is stable
0477008786f63041d951ddb0571a6f5641aa80bc
+  if (!priv->sessions_opened)
+    {
+      /* At the point where we opened the sessions we're accepted i
+         in the call ? */
+      gabble_base_call_channel_set_state ( GABBLE_BASE_CALL_CHANNEL (self),
+          GABBLE_CALL_STATE_ACCEPTED);
+    }

This comment doesn't instill a great deal of confidence and/or you've got a
dangling 'i'.


Implement hanging up properly
1415b81a5d093c8b7a3733bbb805181cf0681415
+    # happyness.. Now let's hang up
+    channel.Hangup (0, "", "", dbus_interface=cs.CHANNEL_TYPE_CALL)

s/happyness/happiness/


Add API to shut down members
8685e7f1577de05e5bbd4d15133af5c587d67782

Jingle function calls are almost completely factored out :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.