[Bug 25236] TpBaseClient - initially, Client and Observer support

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Apr 29 09:12:54 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=25236

--- Comment #37 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-04-29 00:12:54 PDT ---
(In reply to comment #36)
> (In reply to comment #34)
> > > >   61  * Signature of the implementation of the ObserveChannels method.
> > > >   62  * This function MUST call tp_observe_channels_context_accept,
> > > >   63  * tp_observe_channels_context_delay or tp_observe_channels_context_fail.
> > > 
> > > This isn't an RFC (or telepathy-spec, which pretends to be one) so I'd be
> > > inclined to not capitalize MUST. How about this?
> > > 
> > >  * Signature of the implementation of the ObserveChannels method.
> > >  *
> > >  * This function must call either tp_observe_channels_context_accept,
> > >  * tp_observe_channels_context_delay or tp_observe_channels_context_fail
> > >  * on @context before it returns.
> > 
> > changed.
> 
> I don't see this in the branch, did you forget to push it?
> 
> > > > +      DEBUG ("Failed to register bus name %s\n", string->str);
> > > 
> > > Remove \n
> > 
> > done.
> 
> I don't see this either?

Humm weird; I'm sure I fixed this; I guess I forgot to commit or lost the
patches while jungling with branches.
Anyway, it's pushed now.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list