[Bug 29358] Introspect TpError

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29358

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|telepathy-bugs at lists.freede |bugzilla at tecnocode.co.uk
                   |sktop.org                   |

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-02 06:15:07 PDT ---
> + * tp_error_get_dbus_name: (skip)

This should probably be visible to g-i: it's quite useful. Annotate its return
as (transfer none) and it should work fine.

> + * Since: 0.11.12

When adding API, please always say "Since: 0.11.UNRELEASED" (with
capitalization), to avoid having false documentation if a release happens
before a branch is merged. Replacing "UNRELEASED" is part of the release
process.

I'd prefer it if tp_error_quark() was literally just "return
tp_errors_quark()", to avoid the possibility that they don't match.

As implemented, I suspect that calling tp_error_quark();tp_errors_quark() will
also cause warnings/criticals in dbus-glib, as we try to register the same
error domain twice (the two functions currently use different variables for
their "once" guard). Implementing one in terms of the other would also fix
this.

Not putting tp_error_quark in telepathy-glib-sections.txt will break the build.
You don't need to actually document it - just put it under <SUBSECTION
Standard> next to tp_errors_quark.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.