[Bug 28367] Add StreamTube interface support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28367

--- Comment #10 from Andre Moreira Magalhaes <andrunko at gmail.com> 2010-08-02 08:26:26 PDT ---
Here follows a quick review, further review will be done after these "issues"
are handled:

General notes:
- On documentation use the constants such as 
TELEPATHY_INTERFACE_CHANNEL_INTERFACE_TUBE instead of using the string literal.
- Indicate on documentation that method X requires FeatureX, see other docs for
example. The account class documentation is very complete
- \return instead of \returns
- Remove __k__ and similar from all methods, vars, etc.
- Use the include directives as done in other classes, meaning that all
included 
are at the top of the file, following a certain order, check other classes as 
reference.
- Remove the connectNotify stuff, we don't do that in any other class. The user 
should know what he is doing and the docs should state which features the
signals
depend on.
- Do not use Q_PRIVATE_SLOT, just do as done in other class using "private
Q_SLOTS"
- Use include QtSomething instead of QtFoo/QtSomething
- Never use public vars, add accessors for all members that may be accessed.
- Do not use Q_D, Q_Q, we may change that in the future but for now we don't
use 
it anywhere, so let's just stick to mPriv for standardization
- Methods should be declared first, then vars.
- Try to initialize mPriv members inside mPriv constructor instead of doing
mPriv->foo = bla inside class constructor.

On TubeChannel::Private constructor, when defining a introspectable, make it 
like this:
    ReadinessHelper::Introspectable introspectableTube(
        QSet<uint>() << 0,                                           //
makesSenseForStatuses
        Features() << Channel::FeatureCore,                          //
dependsOnFeatures (core)
        QStringList() << TELEPATHY_INTERFACE_CHANNEL_INTERFACE_TUBE, //
dependsOnInterfaces
        (ReadinessHelper::IntrospectFunc) &Private::introspectTube,
        this);

Doing this there is no need to check if the interface is present on 
Private::introspectTube. Just do:
    Client::ChannelInterfaceTubeInterface *tubeInterface = 
        parent->tubeInterface(BypassInterfaceCheck);

+                   
QLatin1String(TELEPATHY_INTERFACE_CHANNEL_TYPE_FILE_TRANSFER)),
This should be tube instead of ft.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.