[Bug 21735] Gabble should use ConnectionError to give better errors

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Aug 3 15:31:09 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=21735

--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2010-08-03 06:31:09 PDT ---
In 34cda73:

+    case WOCKY_XMPP_STREAM_ERROR_CONFLICT:
+      /* Assume we got this while already signed-in, rather than while
+       * connecting (which would be ALREADY_CONNECTED). */
+      return set_conn_reason (conn_reason,
+          TP_CONNECTION_STATUS_REASON_NAME_IN_USE,
+          TP_ERROR_CONNECTION_REPLACED);
+

Why is this assumption safe?

Otherwise, looks fine.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list