[Bug 29358] Introspect TpError

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29358

--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-03 09:02:42 PDT ---
(In reply to comment #3)
> Apparently the introspection scanner is broken if adding a "Rename to:"
> annotation doesn't work for renaming tp_errors_quark() to tp_error_quark()
> (which it didn't). I don't know if you want to hold on this patch until the
> scanner is fixed, to save introducing new API unnecessarily.

Every time we add a D-Bus method we gain 2 extern symbols, so I think adding
tp_error_quark() would be the least of our worries :-)

> For this work to be most useful for libfolks, the generated VAPI file needs to
> interpret the error enum correctly as an error domain. That requires this bug
> to be fixed: https://bugzilla.gnome.org/show_bug.cgi?id=625837. That shouldn't
> block this bug though.

You say "most useful". Does it still improve libfolks (a bit) if we add
tp_error_quark(), even before 625837 is fixed?

If it does, tp_error_quark is probably worthwhile to merge; if it doesn't, wait
and see whether 625839 gets fixed before 625837.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.