[Bug 13422] Add nice API for channel creation

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Aug 4 12:47:07 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=13422

--- Comment #21 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-04 03:47:06 PDT ---
The tests look fine.

A missing bit of API here that I think clients will want in practice: if the
channel is re-requested and HandleChannels is called on the hidden handler,
something ought to emit a signal to the API user so they can put their window
in the foreground.

We only give the API user a TpChannel at the moment, and bolting an unrelated
and non-guaranteed signal onto TpChannel seems wrong, so we'd have to introduce
a new object:

TpChannel *tp_account_create_and_handle_channel_finish (TpAccount *account,
    GAsyncResult *result,
    TpHandlerNotifier *notifier,
    GError **error)

where notifier may be NULL, and if not, *notifier is set to a trivial object
that just emits a signal every time the channel is re-handled?

The signal that's emitted on re-handling ought to contain the
TpHandleChannelsContext, so the handler can look at the
TpHandleChannelsContext:handler-info if it wants to. Perhaps the _finish
function should also optionally output a TpHandleChannelsContext?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list