[Bug 28915] MC does not save "old-ssl" flag

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28915

--- Comment #2 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-09 06:07:08 PDT ---
Does this need backporting to 5.4?

> +            buf = g_strdup_printf ("%u", g_value_get_uint (value));
> +            g_key_file_set_string (keyfile, name, key, buf);

> +gboolean
> +mcd_account_manager_set_account_value (McdAccountManager *account_manager,
> +                                       McdAccount *account,
> +                                       const gchar *key,
> +                                       const GValue *value)

It might be useful to replace @account with the string "unique name" (object
path tail), or the object path, of the account (whichever is more
conventional).

Could this usefully be a method on the McdPluginAccountManager, or even a
non-virtual convenience method on the McpAccountManager GInterface? That would
break the circular dependency between McdAccountManager and McdAccount.

(At some point McdPluginAccountManager should probably be called
McdStoredAccounts or something; that's what it does, really.)

If these methods are needed by plugins they should probably go in
McpAccountManager; otherwise, they should be G_GNUC_INTERNAL'd,
underscore-prefixed, and moved to mcd-account-manager-priv.h, so that they're
not API for libmissioncontrol-server.

> +    /* NOTE: we used to purge the account from all stores here but *
> +     * that's handled in mcd_account_delete() by a call to the new *
> +     * mcd_account_manager_forget_account() helper now.            */

I'm not sure that this comment adds anything to people's understanding of the
current code. It'd be better as part of the git commit message, perhaps?

I'd really prefer it if you hadn't re-indented match_account_parameter(), or at
least if you'd made that into a separate commit. Keep it now, though.

> Remove direct AM access from account-compat

Can we delete this code yet? :-P

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.