[Bug 28915] MC does not save "old-ssl" flag

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28915

--- Comment #4 from Vivek Dasmohapatra <vivek at collabora.co.uk> 2010-08-09 10:37:31 PDT ---
(In reply to comment #2)
> Does this need backporting to 5.4?

Nope, we're good there. The plugin stuff doesn't happen in 5.4, so 
although the bug can theoretically exist, nothing exposes it.

> It might be useful to replace @account with the string "unique name" (object
> path tail), or the object path, of the account (whichever is more
> conventional).

All the things that end up fiddling with the internal structure (in the 
existing code) start by calling a method on the McdAccount, so it's really 
6 of 1 as to who gets the unique name from the account - if you think it 
needs changing, I can change it but I don't think it makes much difference.

--

> Could this usefully be a method on the McdPluginAccountManager, or even a
> non-virtual convenience method on the McpAccountManager GInterface? That would
> break the circular dependency between McdAccountManager and McdAccount.

At the moment, the account manager is the thing that wrangles the storage
plugins and makes sure they're called in the right order and so forth:
Since the storage plugins don't know about each other, they can't (currently)
handle things where a decision needs to be made about who gets the account
setting, (or the account), it has to be the AM for now.

--

> (At some point McdPluginAccountManager should probably be called
> McdStoredAccounts or something; that's what it does, really.)

Noted for future work.

--

> If these methods are needed by plugins they should probably go in
> McpAccountManager; otherwise, they should be G_GNUC_INTERNAL'd,
> underscore-prefixed, and moved to mcd-account-manager-priv.h, so that they're
> not API for libmissioncontrol-server.

They're not needed for plugins but there do appear to be bits of 
libmcserver's users that also steal the AMs storage and fiddle with 
them, I'll need to patch them up to use the new abstractions (in 
progress), and bump their dependencies.

--

> I'm not sure that this comment adds anything to people's understanding of the
> current code. It'd be better as part of the git commit message, perhaps?

Ok.

> I'd really prefer it if you hadn't re-indented match_account_parameter(),
> or at least if you'd made that into a separate commit. Keep it now, though.

Oops, hadn't noticed that.

> > Remove direct AM access from account-compat
> Can we delete this code yet? :-P

Good question. There are chunks of libmcserver's users which use 
some of this stuff, but some of those chunks can go away now: I'm 
just not sure exactly how much of those use cases is dead code at 
this point. We can probably start pruning it rather than adding to 
it.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.