[Bug 29375] add something resembling GabbleBaseChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29375

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2010-08-10 14:26:19 PDT ---
(In reply to comment #3)
> I've started implementing this on my base-channel branch here:
> http://git.collabora.co.uk/?p=user/jonathon/telepathy-glib;a=shortlog;h=refs/heads/base-channel
> 
> So far I've ported a single example CM (the 'echo' example), which shows a nice
> trend:
> examples/cm/echo/chan.c |  381 +++++------------------------------------------
>  examples/cm/echo/chan.h |   10 +-
>  2 files changed, 39 insertions(+), 352 deletions(-)
> 
> If you have some time, I would appreciate a quick 'pre-review' before I finish
> porting all of the other examples.

You're missing a way to set 'interfaces' on an instance, now that it's in a
Priv structure. Possibly others, I haven't checked; and maybe I missed the
adding of a setter.

(I actually would lean towards not making these private, because it saves so
much typing in subclasses which frequently access, say, the target handle. But
maybe this is anathema? I was just thinking “hey I'm glad these fields are
public” while porting a Ring channel to use the version copied from Gabble
earlier today... ☺)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.