[Bug 29502] FTBFS with gcc-4.5

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29502

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://http://git.collabora |http://http://git.collabora
                   |.co.uk/?p=user/cosimoc/tele |.co.uk/?p=user/smcv/telepat
                   |pathy-gabble.git;a=shortlog |hy-gabble-smcv.git;a=shortl
                   |;h=refs/heads/gcc4.5        |og;h=refs/heads/enums
             Status|NEW                         |ASSIGNED
           Keywords|                            |patch
                 CC|                            |cosimoc at gnome.org

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-11 04:55:39 PDT ---
Here are (IMO) some better fixes for gcc 4.5 compilation:

* the muc-channel patch in the previous branch was hiding a genuine bug, which
gcc spotted for us :-)

* the tube and Jingle things were some minor abuse of numerically-equal enums -
harmless, but confusing - which I've tidied up

* in gabble_media_factory_get_contact_caps we did in fact know better than the
compiler, so I added a cast, together with a comment explaining why we're right

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.