[Bug 29375] add something resembling GabbleBaseChannel

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Aug 11 15:49:47 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=29375

jonner <jonathon at quotidian.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #6 from jonner <jonathon at quotidian.org> 2010-08-11 06:49:46 PDT ---
(In reply to comment #4)
> You're missing a way to set 'interfaces' on an instance, now that it's in a
> Priv structure. Possibly others, I haven't checked; and maybe I missed the
> adding of a setter.

Oh, you're right.  I didn't add any setters since I figured they were all
available as gobject properties, but now that I look back at the code, several
of the properties ("interfaces" for instance) are read-only.  I definitely need
to fix that.

> (I actually would lean towards not making these private, because it saves so
> much typing in subclasses which frequently access, say, the target handle. But
> maybe this is anathema? I was just thinking “hey I'm glad these fields are
> public” while porting a Ring channel to use the version copied from Gabble
> earlier today... ☺)

hm.  is it really going to save that much typing?  I'm a bit hesitant to expose
too much in the struct itself.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list