[Bug 21735] Map all Wocky errors to an appropriate TpError

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21735

--- Comment #11 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-11 09:49:29 PDT ---
WOCKY_XMPP_STREAM_ERROR
=======================

This is the urn:ietf:params:xml:ns:xmpp-streams vocabulary from RFC 3920 (XMPP
Core). We don't cover it very well at the moment.

We currently map <bad-format/> and all the other "your XML is bad" errors
(<bad-namespace-prefix/>, <invalid-xml/>, <restricted-xml/>,
<unsupported-encoding/>, and <xml-not-well-formed/>) to NetworkError. I think
it's reasonable to conflate them all into one code, but we could perhaps
introduce ServiceDenied or something for these "the server says we were wrong"
errors?

<conflict/> is handled already.

<connection-timeout/> deserves a ServiceTimeout error ("dropped by the server
for being idle"), I think.

<host-unknown/> is currently AuthenticationFailed (because in practice it
probably means we're logging in to the wrong server), but it probably deserves
an error code, HostUnknown or WrongServer or something. <host-gone/> could be
the same or distinct.

<improper-addressing/> only affects s2s AFAICS, so we don't need to care.

<internal-server-error/> deserves a code, perhaps ServiceInternalError.
<remote-connection-failed/> is probably the same (it's the server's problem,
not ours).

<invalid-from/>, <invalid-id/>, <invalid-namespace/>, <not-authorized/>,
<unsupported-stanza-type/>, <unsupported-version/> are all the same as
<bad-format/> from our point of view. (Note that <not-authorized/> is *not*
PermissionDenied - it's complaining about Gabble's behaviour, not about user
behaviour.)

<policy-violation/> might deserve its own error or be PermissionDenied.

<resource-constraint/> isn't currently mapped, but should be ServiceBusy.

<see-other-host/> has special semantics - it has XML cdata which is the
hostname or IP address. We need to get that into the ConnectionError details
somehow, which probably means GabbleConnection handling it specially.

<system-shutdown/> deserves its own error code, perhaps ServiceShutdown.

<undefined-condition/> is anyone's guess. Perhaps we should follow D-Bus'
example and introduce Failed, which explicitly means "we just don't know", or
perhaps we should use NotAvailable.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.