[Bug 21735] Map all Wocky errors to an appropriate TpError

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=21735

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-08-13 05:28:44 PDT ---
WOCKY_CONNECTOR_ERROR (second half)
===================================

BIND_REJECTED is any unrecognised WOCKY_XMPP_ERROR in reply to resource
binding. In the regression tests, this is tested via the well-known
<badger-badger-badger-mushroom/> error :-) This is a job for NotAvailable or a
new Failed, perhaps.

SESSION_FAILED is a nonsensical reply or internal server error while
establishing the session. NotAvailable? NetworkError? ServiceInternalError?

SESSION_DENIED is <forbidden/>. PermissionDenied? CSR_Authentication_Failed?

SESSION_CONFLICT is <conflict/> in reply to session establishment; it's not
currently handled in Gabble, afaics, but should be mapped to AlreadyConnected.

The JABBER_AUTH sub-family of errors don't actually appear to be used anywhere.

INSECURE is an attempt to do XEP-0077 registration over an unencrypted
connection when this was disallowed, so, EncryptionNotAvailable.

REGISTRATION_FAILED is a nonsensical reply, or any reply other than
<service-unavailable>, to the registration form request, or any error stanza
when submitting the form that doesn't have a more specific meaning. I don't
think there's anything very useful we can do with this?

REGISTRATION_UNAVAILABLE is <service-unavailable> on the registration form
request: clearly ServiceBusy.

REGISTRATION_CONFLICT is <conflict/> on the registration form submission, and
is already mapped to RegistrationExists.

REGISTRATION_REJECTED is <not-acceptable/> on the registration form submission,
or a registration form that requires email when we didn't supply one. We
currently map this to PermissionDenied and CSR_Authentication_Failed, but
that's a bit rubbish, perhaps?

REGISTRATION_UNSUPPORTED is a registration form that contains fields other than
username, password and email. We currently use NotAvailable and
CSR_Authentication_Failed.

REGISTRATION_EMPTY is a registration form with no fields, which makes no sense.
We don't map this; it could be ServiceInternalError?

UNREGISTER_DENIED is <forbidden/> or <not-allowed/>. UNREGISTER_FAILED is any
other failure to unregister. We don't support unregistration in Gabble anyway,
so these don't really need mapping yet.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.